Skip to content

[5.9][build-script] Install 'earlyswiftsyntax' if 'install-swift' is off #68463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Sep 12, 2023

Cherry-pick #68462 into release/5.9

  • Explanation: Some build scenarios (e.g. lldb) want swift-syntax libraries be installed, but don't want to install "swift" compiler products. Install earlyswiftsyntax products independently when --install-swiftsyntax is specified but --install-swift is NOT specified.
  • Scope: Build system
  • Risk: Low, this doesn't affect majority of build presets.
  • Testing: Passes current test suite
  • Isssues: TBA
  • Reviewer: Ben Barham (@bnbarham)

Some build scenario (e.g. lldb) want swift-syntax libraries installed
but don't want to install "swift" compiler products.

Install 'earlyswiftsyntax' products independently when
'--install-swiftsyntax' is specified but '--install-swift' is NOT
specified.

(cherry picked from commit 466eb9a)
@rintaro rintaro requested a review from a team as a code owner September 12, 2023 18:55
@rintaro
Copy link
Member Author

rintaro commented Sep 12, 2023

@swift-ci Please test

@rintaro rintaro changed the title [build-script] Install 'earlyswiftsyntax' if 'install-swift' is off [5.9][build-script] Install 'earlyswiftsyntax' if 'install-swift' is off Sep 12, 2023
@rintaro rintaro merged commit aaafc31 into swiftlang:release/5.9 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants