[🍒] Revert 46f86f0870cf64e649034851d149e735dfb5a14b #68437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 46f86f0.
zoecarver
requested review from
hborla,
slavapestov,
xedin,
ahoppen,
bnbarham,
rintaro,
hamishknight,
shahmishal,
compnerd,
adrian-prantl,
ktoso,
AnthonyLatsis,
QuietMisdreavus,
artemcm,
CodaFi,
DougGregor,
hyp,
egorzhdan,
MaxDesiatov,
etcwilde,
kavon,
al45tair,
tshortli and
eeckstein
as code owners
|
@swift-ci please test |
…sts" This reverts commit f20617b.
zoecarver
force-pushed
the
5.9/revert-46f86f0870cf64e649034851d149e735dfb5a14b
branch
from
fbe5038 to
2bd330e
Compare
|
@swift-ci please test |
bnbarham
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Importing names and building the lookup table happens when building clang modules. This means we may not have a valid clang AST (context) and the clang module loader may be null. #67865 introduced a use of the clang module loader when doing name lookup which meant we crashed when emitting the bridging header as a pch.
Scope: Any interop emitting a pch, potentially wider scope (any C, ObjC, C++ interop).
Risk: Low. This is a revert.
Testing: Unit testing (CI)
Radar: rdar://115282612
Original PR: #68435