Skip to content

When building for baremetal targets, accept any arch that LLVM supports #67093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2023
Merged

When building for baremetal targets, accept any arch that LLVM supports #67093

merged 1 commit into from
Jul 4, 2023

Conversation

kubamracek
Copy link
Contributor

No description provided.

@kubamracek kubamracek marked this pull request as ready for review July 3, 2023 17:00
@kubamracek
Copy link
Contributor Author

@swift-ci please test

rauhul
rauhul approved these changes Jul 3, 2023
View reviewed changes
Copy link
Member

@rauhul rauhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth/possible to upstream OS none to LLVM?

@kubamracek
Copy link
Contributor Author

Would it be worth/possible to upstream OS none to LLVM?

Note that LLVM already accepts "none" as the OS part of the triple, but it gets parsed as "unknown OS" (OSType::UnknownOS) rather than an explicit "baremetal OS". And interestingly, UnknownOS already has a lot of the properties a "baremetal OS" should have. But yes, I agree that it would nice to formalize that.

compnerd
compnerd approved these changes Jul 3, 2023
View reviewed changes
@kubamracek kubamracek force-pushed the none-os-allow-any-arch branch from 06cd000 to 2792eb2 Compare July 4, 2023 02:39
@kubamracek
Copy link
Contributor Author

@swift-ci please test

@kubamracek
Copy link
Contributor Author

@swift-ci please test Windows platform

@kubamracek kubamracek merged commit 47b73eb into swiftlang:main Jul 4, 2023
@kubamracek kubamracek deleted the none-os-allow-any-arch branch July 4, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

@rauhul rauhul rauhul approved these changes

@jckarter jckarter Awaiting requested review from jckarter

@zoecarver zoecarver Awaiting requested review from zoecarver

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubamracek @compnerd @rauhul