Skip to content

[5.9] Disable taskgroup test on freestanding; they're not supported #66182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented May 26, 2023

Cherry pick of: #66181

rdar://109899236

Since none of the task group APIs are usable in freestanding, disable this freshly added test there as well:

-- Testing: 24 of 16230 tests, 10 workers --
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_cancelAll_only_specific_group.swift (1 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_asynciterator_semantics.swift (2 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_cancel_parent_affects_group.swift (3 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_cancel_then_spawn.swift (4 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_discarding_neverConsumingTasks.swift (5 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_discarding_dontLeak_class_error.swift (6 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_dontLeakTasks.swift (7 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_task_locals_prevent_illegal_use_taskgroup.swift (8 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_discarding_dontLeak.swift (9 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_next_not_invoked_cancelAll.swift (10 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_cancel_then_completions.swift (11 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/taskgroup_cancelAll_cancellationHandler.swift (12 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_next_not_invoked_without_cancelAll.swift (13 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_discarding.swift (14 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_next_on_pending.swift (15 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_is_empty.swift (16 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_throw_recover.swift (17 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/taskgroup_cancelAll_from_child.swift (18 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_task_locals_prevent_illegal_use_discarding_taskgroup.swift (19 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_throw_rethrow.swift (20 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_task_cancellation_taskGroup.swift (21 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_next_on_completed.swift (22 of 24)
UNSUPPORTED: Swift(freestanding-x86_64) :: Sanitizers/tsan/async_taskgroup_next.swift (23 of 24)
PASS: Swift(freestanding-x86_64) :: Concurrency/Runtime/async_taskgroup_is_asyncsequence.swift (24 of 24)

@ktoso ktoso requested a review from a team as a code owner May 26, 2023 19:51
@ktoso
Copy link
Contributor Author

ktoso commented May 26, 2023

@swift-ci please test and merge

@@ -1,8 +1,8 @@
// RUN: %target-run-simple-swift( -Xfrontend -disable-availability-checking -parse-as-library) | %FileCheck %s
// TODO: move to target-run-simple-leaks-swift once CI is using at least Xcode 14.3

// This test uses `leaks` which is only available on apple platforms; limit it to macOS:
// REQUIRES: OS=macosx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure we should remove this line? Does this test really run on Linux and Windows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is actually on purpose, but I did miss removing the import Darwin 😮‍💨 (that wasn't used, fixed now).

The reason for macos here is explained in the TODO above: // TODO: move to target-run-simple-leaks-swift once CI is using at least Xcode 14.3 so there's a new way to tests for leaks, but only Xcode 14.3 seems to be reliable enough in reporting them, so once we do that we can make this test use leaks and require macos

@ktoso
Copy link
Contributor Author

ktoso commented May 26, 2023

@swift-ci please test

@hamishknight
Copy link
Contributor

Merging to fix CI

@hamishknight hamishknight merged commit 72718c0 into swiftlang:release/5.9 May 27, 2023
@ktoso ktoso deleted the pick-disable-in-freestanding branch July 19, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants