Skip to content

[cherry-pick][release/5.9] [Build] Build libcxx on lldb ASAN/UBSAN bots #66079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Michael137
Copy link
Contributor

The preset for ubsan/asan buildbots include the
buildbot_incremental_base preset, which builds/runs tests. But the tests now require libcxx to be built since #66018

(cherry picked from commit 7893c8e)

@Michael137 Michael137 requested a review from a team as a code owner May 23, 2023 16:30
@Michael137
Copy link
Contributor Author

@swift-ci test

@Michael137 Michael137 requested a review from adrian-prantl May 23, 2023 16:31
@@ -316,6 +316,7 @@ skip-early-swift-driver
#===------------------------------------------------------------------------===#

[preset: buildbot_incremental_base]
libcxx
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be more targeted at LLDB presets?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

,lldb_asan_ubsan

Copy link
Contributor

@adrian-prantl adrian-prantl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lldb_asan_ubsan

@Michael137
Copy link
Contributor Author

preset=buildbot_incremental,lldb_asan_ubsan
@swift-ci Please test with preset macOS platform

The preset for ubsan/asan buildbots include the
`buildbot_incremental_base` preset, which builds/runs
tests. But the tests now require libcxx to be built
since swiftlang#66018

(cherry picked from commit 7893c8e)
@Michael137 Michael137 force-pushed the bugfix/lldb-asan-bots-libcxx-testing-to-5.9 branch from 7e0f231 to d8a2514 Compare May 27, 2023 12:55
@Michael137
Copy link
Contributor Author

preset=buildbot_incremental,lldb_asan_ubsan
@swift-ci Please test with preset macOS platform

@Michael137
Copy link
Contributor Author

preset=buildbot_incremental,lldb_asan_ubsan
@swift-ci Please test with preset macOS

@Michael137
Copy link
Contributor Author

@swift-ci test

1 similar comment
@Michael137
Copy link
Contributor Author

@swift-ci test

@Michael137
Copy link
Contributor Author

preset=buildbot_incremental,lldb_asan_ubsan
@swift-ci Test macOS Platform with preset

@Michael137
Copy link
Contributor Author

preset=buildbot_incremental,lldb_asan_ubsan
@swift-ci please test with preset macOS

@adrian-prantl adrian-prantl merged commit 0a6e762 into swiftlang:release/5.9 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants