Build indexstore-db and sourcekit-lsp in a unified SwiftPM build #60308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoppen
force-pushed
the
pr/unified-build-indexstore-db-sourcekit-lsp
branch
from
1f6b38e to
72c64ac
Compare
ahoppen
changed the title
benlangmuir
approved these changes
Aug 5, 2022
bnbarham
approved these changes
Aug 5, 2022
Comment on lines
4
to
19
| <FileRef location = "group:../../../../indexstore-db"></FileRef> | ||
| <FileRef location = "group:../../../../llbuild"></FileRef> | ||
| <FileRef location = "group:../../../../sourcekit-lsp"></FileRef> | ||
| <FileRef location = "group:../../../../swift-argument-parser"></FileRef> | ||
| <FileRef location = "group:../../../../swift-collections"></FileRef> | ||
| <FileRef location = "group:../../../../swift-docc"></FileRef> | ||
| <FileRef location = "group:../../../../swift-driver"></FileRef> | ||
| <FileRef location = "group:../../../../swift-format"></FileRef> | ||
| <FileRef location = "group:../../../../swift-stress-tester/SourceKitStressTester"></FileRef> | ||
| <FileRef location = "group:../../../../swift-stress-tester/SwiftEvolve"></FileRef> | ||
| <FileRef location = "group:../../../../swift-syntax"></FileRef> | ||
| <FileRef location = "group:../../../../swift-system"></FileRef> | ||
| <FileRef location = "group:../../../../swift-tools-support-core"></FileRef> | ||
| <FileRef location = "group:../../../../swiftpm"></FileRef> | ||
| <FileRef location = "group:../../../../yams"></FileRef> |
There was a problem hiding this comment.
Should this just be adding indexstore/lsp?
There was a problem hiding this comment.
sourcekit-lsp brings in additional dependencies that are also added here
- swift-argument-parser
- swift-tools-support-core
- swiftpm
- llbuild
- swift-system
- swift-driver
- yams
- swift-collections
Actually, are we missing swift-crypto @ahoppen? https://github.com/apple/swift-package-manager/blob/73133d3f69d956f16adde38c07c6969e02d6e5a1/Package.swift#L606
There was a problem hiding this comment.
I thought I had walked the entire dependency tree but apparently I missed that. Thanks for noticing
There was a problem hiding this comment.
Oh, of course. I was only thinking about indexstore-db for some reason (I tagged on lsp at the end without really thinking about it). Thanks!
ahoppen
force-pushed
the
pr/unified-build-indexstore-db-sourcekit-lsp
branch
from
72c64ac to
059128f
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please build toolchain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way we don’t need to build indexstore-db twice (once when building indexstore-db itself and once when building sourcekit-lsp). This reduced the smoke testing time by ~5 minutes.