[cxx-interop] Add tests for operator++() that returns void
#59663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
Huddie
reviewed
Jun 23, 2022
| // CHECK: } | ||
|
|
||
| // CHECK: struct HasPreIncrementOperatorWithVoidReturnType { | ||
| // CHECK: func successor() -> HasPreIncrementOperatorWithVoidReturnType |
There was a problem hiding this comment.
Shouldn't this function be mutating and just update the value in lhs.value or something? Feels odd that a void function in Cxx is being mapped into a function that returns a type (a copy I assume)
There was a problem hiding this comment.
We don't want to map them differently for a couple reasons:
- We're importing
operator++mainly to make it possible to increment C++ iterators from Swift. If the signature offunc successor() -> Selfchanges depending on the return type ofoperator++, we can't conform iterators to a single protocol (UnsafeCxxInputIterator), and that defeats the purpose of importingoperator++in the first place. - In most C++ use cases, there is no difference between
void operator++()andT& operator++(). I think it would be a bit confusing to introduce it in Swift.
| let anotherReturnTypeResult: HasPreIncrementOperatorWithAnotherReturnType = anotherReturnType.successor() | ||
|
|
||
| let voidReturnType = HasPreIncrementOperatorWithVoidReturnType() | ||
| let voidReturnTypeResult: HasPreIncrementOperatorWithVoidReturnType = voidReturnType.successor() |
There was a problem hiding this comment.
Maybe a check that the successors .value is indeed 1 more than the predecessor
There was a problem hiding this comment.
You're right, we should have an execution test for this.
This pattern was discovered on `llvm::detail::SafeIntIterator` (`llvm/ADT/Sequence.h:153`):
```cpp
// Pre Increment/Decrement
void operator++() { offset(1); }
void operator--() { offset(-1); }
```
rdar://95684692
egorzhdan
force-pushed
the
egorzhdan/cxx-plusplus-void-tests
branch
from
90513c8 to
0f1ef6d
Compare
|
@swift-ci please smoke test |
Huddie
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pattern was discovered on
llvm::detail::SafeIntIterator(llvm/ADT/Sequence.h:153):Previous patch: #59643.
rdar://95684692