[Autolink Extract] Keep a set of linker flags instead of vector #58800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test Linux |
|
@swift-ci smoke test macOS |
|
@swift-ci please test Windows |
artemcm
force-pushed
the
AutoLinkExtractSet
branch
from
e80b867 to
e7ca29d
Compare
|
@swift-ci please test |
artemcm
force-pushed
the
AutoLinkExtractSet
branch
from
e7ca29d to
32e477b
Compare
|
@swift-ci please test |
|
This is iterated over at the tail of |
artemcm
force-pushed
the
AutoLinkExtractSet
branch
from
32e477b to
9f0abea
Compare
|
@swift-ci please test |
artemcm
force-pushed
the
AutoLinkExtractSet
branch
from
9f0abea to
476db5b
Compare
|
@swift-ci please test |
tomerd
approved these changes
May 14, 2022
artemcm
force-pushed
the
AutoLinkExtractSet
branch
2 times, most recently
from
417d108 to
3142b87
Compare
|
@swift-ci please test |
artemcm
force-pushed
the
AutoLinkExtractSet
branch
from
3142b87 to
d2f4a98
Compare
|
@swift-ci please test |
Otherwise we can duplicate linker flags across input binaries, which can result in very large linkerr invocation commands. Resolves swiftlang#58380
artemcm
force-pushed
the
AutoLinkExtractSet
branch
from
d2f4a98 to
10a187d
Compare
|
@swift-ci please test |
|
I have concerns over this change. This subtly changes the linker behaviour in an unexpected way potentially. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we can duplicate linker flags across input binaries, which can result in very large linkerr invocation commands.
Resolves #58380