-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[android] Don't generate a libstdcxx.modulemap #58497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Android uses libc++, which already has its own module map.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to get the CI back to green, but please do open an issue and tag it - we really should try to get C++ interop working on Android as well.
Will open an issue, but could you explain what I should do to "tag it?"
It mostly works, with the Android CI only broken because some new Interop tests were added late last year that happen to interact badly with how Android organizes its C headers. Also, my pull #40779 that moved some Swift memory tags broke one test on the CI. Once this is in, I'll look at those remaining failing tests. |
Oh, just reference the issue in the commit message ideally (e.g. this should be enabled and #... tracks it type of thing) or just reference the PR from the issue.
Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@egorzhdan, if you would just run the CI, we can get this in. |
@swift-ci please smoke test |
Thanks for the quick turnaround. |
Therefore, do not generate a libstdcxx.modulemap. See also swiftlang#58497.
Android uses libc++, which already has its own module map.
@egorzhdan, as we discussed, removing this, as I noticed it breaks some tests on the Android CI too.
@compnerd, letting you know in case you have any input.