Skip to content

Allow demangling of methods in extensions #5133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2016
Merged

Allow demangling of methods in extensions #5133

merged 1 commit into from
Oct 5, 2016

Conversation

egranata
Copy link
Contributor

@egranata egranata commented Oct 5, 2016 

Add enough logic to TypeReconstruction to allow LLDB to discover the type of methods in protocol extensions, such as e.g.

extension Collection {
  func group<Key: Hashable>(f: Key) -> Key {...}
}

I have a matching test case for this over in LLDB

Add enough logic to TypeReconstruction to allow LLDB to discover the …
532d106 
…type of methods in protocol extensions, such as e.g.

extension Collection {
  func group<Key: Hashable>(f: Key) -> Key {...}
}

I have a matching test case for this over in LLDB
@egranata
Copy link
Contributor Author

egranata commented Oct 5, 2016

@swift-ci please smoke test

@egranata
Copy link
Contributor Author

egranata commented Oct 5, 2016

I doubt this failure is due to my patch:

FAIL: Swift(macosx-x86_64) :: stdlib/DictionaryAnyHashableExtensions.swift (1310 of 8730)
******************** TEST 'Swift(macosx-x86_64) :: stdlib/DictionaryAnyHashableExtensions.swift' FAILED ********************

Undefined symbols for architecture x86_64:
"TFes0_Rxs8Hashablexs20_AnyHashableProtocolrVs10Dictionary11removeValueuRd__S_rfT6forKeyqd___GSqq"

If I were a bad person, I might suspect #5132 as a more likely culprit. OTOH, it looks like that pull request hasn't merged yet..

@egranata
Copy link
Contributor Author

egranata commented Oct 5, 2016

@swift-ci please smoke test macOS

@egranata egranata merged commit 2adff51 into swiftlang:master Oct 5, 2016
@egranata egranata deleted the find-funcs-in-ext branch October 5, 2016 21:02
@slavapestov
Copy link
Contributor

@egranata I think that was an incremental build issue. I just hit the same error, deleted my build artifacts and built again without seeing it.

@erg Any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egranata @slavapestov