Clock/Instant/Duration #40609
Clock/Instant/Duration #40609
Conversation
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
phausler
force-pushed
the
phausler/clock_instant_duration
branch
from
df3443c to
417d5cb
Compare
|
@swift-ci please build toolchain |
3 similar comments
|
@swift-ci please build toolchain |
|
@swift-ci please build toolchain |
|
@swift-ci please build toolchain |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
@lorentey This is the most recent revision of the proposal implemented - I took your feedback and tried to apply to the new versions but it could definitely use a more detailed review. |
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
|
Linux Toolchain (Ubuntu 16.04) Install command |
phausler
force-pushed
the
phausler/clock_instant_duration
branch
from
ca30ddb to
7516147
Compare
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
|
Linux Toolchain (Ubuntu 16.04) Install command |
| "DoubleWide.swift", | ||
| "Duration.swift", | ||
| "DurationProtocol.swift", | ||
| "Instant.swift" |
There was a problem hiding this comment.
Nit: I think it would make sense to create a new group for these, called "Clock" (or something similar).
|
|
||
| @available(SwiftStdlib 9999, *) | ||
| public struct SuspendingClock { | ||
| public struct Instant: Codable, Sendable { |
There was a problem hiding this comment.
Do we want to provide a CustomStringConvertible conformance for these instant types?
We definitely don't want to print them in a calendrical format, but it might be a good idea to customize the default reflection-based output. (Which looks something like Instant(_value: 23.456 seconds). Would something like T+23.456s be less annoying to read in the long term?)
There was a problem hiding this comment.
probably; good point
|
@swift-ci please smoke test |
|
@swift-ci please build toolchain |
|
Linux Toolchain (Ubuntu 20.04) Install command |
|
@swift-ci please smoke test |
phausler
force-pushed
the
phausler/clock_instant_duration
branch
from
e66b720 to
07de018
Compare
|
@swift-ci please smoke test |
…(SwiftStdlib 9999, *)
…few more missing availabilities
…ding/decoding to string based serialization
…ing/decoding but as unkeyed
phausler
force-pushed
the
phausler/clock_instant_duration
branch
from
08afe34 to
5c24901
Compare
…n, DurationProtocol and InstantProtocol
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
This is a draft implementation of the proposal SE-0329 (with the new revisions from the proposal).
Remaining todo:
tolerance/leeway needs to be passed along to the dispatch side of things.