Skip to content

[cxx-interop] Support function templates inside a namespace. #34607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zoecarver
Copy link
Contributor

Thread "templateParams" through the call to find the function parameter types when the function is in a namespace.

This was an oversight of mine in #33053.

@zoecarver zoecarver added the c++ interop Feature: Interoperability with C++ label Nov 6, 2020
@zoecarver zoecarver requested a review from hlopko November 6, 2020 06:57
Copy link
Contributor

@hlopko hlopko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Thread "templateParams" through the call to find the function parameter
types when the function is in a namespace.
@zoecarver zoecarver force-pushed the cxx/fix/function-template-in-namespace branch from 7280b68 to 9c58a95 Compare November 11, 2020 02:50
@zoecarver
Copy link
Contributor Author

@swift-ci please smoke test.

@zoecarver zoecarver merged commit ad545f8 into swiftlang:main Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants