[cxx-interop] Temporarily disable emitting debug info for C++ types. #32815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribozavr
reviewed
Jul 15, 2020
gribozavr
reviewed
Jul 15, 2020
zoecarver
force-pushed
the
fix/cxx/debug-deserialize
branch
from
d80b8ea to
83a8953
Compare
gribozavr
reviewed
Jul 17, 2020
gribozavr
reviewed
Jul 17, 2020
gribozavr
reviewed
Jul 17, 2020
gribozavr
reviewed
Jul 17, 2020
gribozavr
reviewed
Jul 17, 2020
gribozavr
reviewed
Jul 17, 2020
gribozavr
reviewed
Jul 17, 2020
gribozavr
reviewed
Jul 17, 2020
zoecarver
force-pushed
the
fix/cxx/debug-deserialize
branch
from
83a8953 to
ad3027d
Compare
|
@gribozavr thanks for the review! All fixed. |
gribozavr
approved these changes
Jul 20, 2020
|
@swift-ci Please test |
|
Build failed |
When we try to emit debug info from C++ types we crash because we can't deserialize them. This is a temporary fix to circumnavigate the crash before a real fix can be created.
zoecarver
force-pushed
the
fix/cxx/debug-deserialize
branch
from
ad3027d to
5c3ccf5
Compare
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to emit debug info from C++ types we crash because we can't deserialize them. This is a temporary fix to circumnavigate the crash before a real fix can be created.
Refs #32721.
Edit: https://bugs.swift.org/browse/SR-13223