Qualify the names of extended types in module interfaces #32780
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was previously done inconsistently—we did it for certain generic types, but not otherwise. Now we always do it unless `-module-interface-preserve-types-as-written` has been specified. Fixes SR-13050 / rdar://64947446.
|
Note that this has the potential to cause module interfaces which currently, coincidentally aren't affected by type names shadowing module names to start having trouble with it. (It did in our own test suite!) I need to evaluate the impact of this. @swift-ci please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously done inconsistently—we did it for certain generic types, but not otherwise. Now we always do it unless
-module-interface-preserve-types-as-writtenhas been specified. Fixes SR-13050 / rdar://64947446.