[5.3] [stdlib] Performance fixes for removeFirst and removeLast #32647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions (swiftlang#32599) This replaces the `count` comparison precondition with a limited index offset, which converts the method from O(n) to O(k).
|
@swift-ci Please test |
|
@swift-ci Please test |
kylemacomber
approved these changes
Jul 1, 2020
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picks #32451 and #32599, performance fixes for
removeFirst(_:)andremoveLast(_:)on substrings.• Explanation: Performance improvement for default implementations of the
removeFirst(_:)andremoveLast(_:)methods• Scope of Issue: Performance change only to the Swift standard library
• Risk: Low, the change is constrained to a few default implementations, and does not change semantics
• Testing: Existing unit tests and benchmarks
• Issue: rdar://problem/64994976
• Reviewer: @lorentey