[ownership] Enable GlobalOpt on ossa and add ossa tests #32621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
|
Build failed |
atrick
reviewed
Jul 6, 2020
|
|
||
| @_hasStorage @_hasInitialValue let trivialglobal: TStruct { get } | ||
|
|
||
| @_hasMissingDesignatedInitializers public class TClass { |
There was a problem hiding this comment.
You may need to move extraneous attributes like @_hasMissingDesignatedInitializers and @objc so the test works on non-mac platforms
|
@swift-ci smoke test |
|
@atrick Added comments to |
eeckstein
pushed a commit
to eeckstein/swift
that referenced
this pull request
Oct 29, 2020
) GlobalOpt works mostly on trivial values (there are special cases for ObjectInst and ValueToBridgeObjectInst). optimizeGlobalAccess is explicitly turned off for non-trivial values. optimizeInitializer calls SILGlobalVariable::isValidStaticInitializerInst which limits it to mostly trivial values except for special cases for ObjectInst and ValueToBridgeObjectInst. This changes adds GlobalOpt tests for ossa and enables GlobalOpt on ossa
tbkka
pushed a commit
that referenced
this pull request
Oct 30, 2020
) GlobalOpt works mostly on trivial values (there are special cases for ObjectInst and ValueToBridgeObjectInst). optimizeGlobalAccess is explicitly turned off for non-trivial values. optimizeInitializer calls SILGlobalVariable::isValidStaticInitializerInst which limits it to mostly trivial values except for special cases for ObjectInst and ValueToBridgeObjectInst. This changes adds GlobalOpt tests for ossa and enables GlobalOpt on ossa Co-authored-by: Meghana Gupta <meghanavgupta@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlobalOpt works mostly on trivial values (there are special cases for
ObjectInstandValueToBridgeObjectInst).optimizeGlobalAccessis explicitly turned off for non-trivial values.optimizeInitializercallsSILGlobalVariable::isValidStaticInitializerInstwhich limits it to mostly trivial values except for special cases forObjectInstandValueToBridgeObjectInst.This changes adds GlobalOpt tests for ossa and enables GlobalOpt on ossa