[Frontend] Some pipeline refactoring #32601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
CodaFi
reviewed
Jun 29, 2020
And call from `CompilerInstance::setup`.
Expand the FrontendOptions to allow the enabling of the dependency tracker for non-system dependencies, and switch the previous clients of `createDependencyTracker` over to using this option. This ensures that the dependency tracker is now set only during `CompilerInstance::setup`.
Allow the verification of dependencies before LLVM, allowing the freeing of the ASTContext.
This allows us to remove another condition that was previously preventing the ASTContext from being freed before LLVM.
hamishknight
force-pushed
the
not-yet-over-and-out
branch
from
9e0f6c2 to
553dadd
Compare
|
@swift-ci please test |
hamishknight
changed the title
CodaFi
approved these changes
Jun 30, 2020
hamishknight
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Jun 30, 2020
hamishknight
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Jun 30, 2020
[master-next] Update for swiftlang/swift#32601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move mangling stats, dependency verification, and API dumping to
performEndOfPipeline. In the latter two cases this allows us to free the ASTContext before LLVM.In addition, internalize the creation of the intermodule dependency tracker such that it's only set by
CompilerInstance::setup.