[Dependency Scanner] Use pragma clang module import in the hack file used to invoke the clang dependency scanner.
#32590
Conversation
|
@swift-ci please test |
|
Build failed |
artemcm
force-pushed
the
HackingWithCModules
branch
3 times, most recently
from
7180006 to
5b27b38
Compare
|
@swift-ci test |
|
Build failed |
artemcm
force-pushed
the
HackingWithCModules
branch
from
5b27b38 to
3e03ffd
Compare
|
@swift-ci test |
1 similar comment
|
@swift-ci test |
|
@swift-ci Please test Windows platform |
| /// dependencies. | ||
| /// FIXME: This should go away once Clang's dependency scanning library | ||
| /// can scan by module name. | ||
| std::string importHackFile; | ||
| llvm::DenseMap<StringRef, std::string> importHackFileCache; |
There was a problem hiding this comment.
Please use StringMap here, because I don't think it's guaranteed that the keys will live forever (and they won't be that large overall).
…e used to invoke the clang dependency scanner. Using `@import` does not woth in C-mode(`-disable-objc-interop`), so C modules cannot be found in this mode. This also means the dependency scanner is not able to invoke the Clang dependency scanner tool on Linux at all.
artemcm
force-pushed
the
HackingWithCModules
branch
from
3e03ffd to
9ee4ebf
Compare
|
@swift-ci test |
|
Build failed |
|
Build failed |
|
@swift-ci test Linux platform |
|
Build failed |
|
@swift-ci please test platform Linux |
|
@swift-ci clean test Linux |
Using
@importdoes not with in C-mode (-disable-objc-interop), so C modules cannot be found in this mode.This also means the dependency scanner is not able to invoke the Clang dependency scanner tool on Linux.