test: attempt to quote python interpreter path #32573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test Windows platform |
Attempt to properly quote the python interpreter path in the lit configuration. This was quoted in some places but not others. This attempts to homogenise the path quoting.
compnerd
force-pushed
the
aspirational-quotes
branch
from
23b9e8a to
6d63d95
Compare
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
|
CC: @tachoknight @drexin @yln |
yln
reviewed
Jun 29, 2020
| @@ -377,7 +377,8 @@ config.substitutions.append( ('%validate-incrparse', '%{python} %utils/incrparse | |||
| config.substitutions.append( ('%incr-transfer-tree', '%{python} %utils/incrparse/incr_transfer_tree.py --temp-dir %t --swift-syntax-test %swift-syntax-test') ) | |||
| config.substitutions.append( ('%swift_obj_root', config.swift_obj_root) ) | |||
| config.substitutions.append( ('%swift_src_root', config.swift_src_root) ) | |||
| config.substitutions.append( ('%{python}', sys.executable) ) | |||
| config.substitutions.append( ('%{python}', pipes.quote(sys.executable)) ) | |||
| config.substitutions.append( ('%{python.unquoted}', sys.executable) ) | |||
There was a problem hiding this comment.
This is the actual change as discussed in #32571.
yln
approved these changes
Jun 29, 2020
|
@swift-ci please test macOS platform |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please test Linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to properly quote the python interpreter path in the lit configuration. This
was quoted in some places but not others. This attempts to homogenise the path quoting.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.