Skip to content

[SourceKit] Enable ASTContext caching in other completion-like requests #32572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 30, 2020
Merged

[SourceKit] Enable ASTContext caching in other completion-like requests #32572

merged 3 commits into from
Jun 30, 2020

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Jun 26, 2020

TypeContextInfo and ConformingMethodList

rdar://problem/64782333

@rintaro
[SourceKit] Enable ASTContext caching in other completion-like requests
bbec1eb 
TypeContextInfo and ConformingMethodList

rdar://problem/64782333
@rintaro
Copy link
Member Author

rintaro commented Jun 26, 2020

@swift-ci Please Build Toolchain macOS

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - bbec1eb

Install command
tar -zxf swift-PR-32572-531-osx.tar.gz --directory ~/

@rintaro
Copy link
Member Author

rintaro commented Jun 29, 2020

@swift-ci Please smoke test

@rintaro rintaro force-pushed the sourcekit-fast-completionlikereq-rdar64782333 branch from 16a3513 to 8307c6a Compare June 29, 2020 17:21
@rintaro
Copy link
Member Author

rintaro commented Jun 29, 2020

@swift-ci Please smoke test

@rintaro rintaro marked this pull request as ready for review June 29, 2020 18:22
@rintaro rintaro requested a review from benlangmuir June 29, 2020 18:23
benlangmuir
benlangmuir reviewed Jun 29, 2020
View reviewed changes
Copy link
Contributor

@benlangmuir benlangmuir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add an option for this like we do with regular code-completion so that it's possible to disable, even if we default to true.

@rintaro
[SouceKit] Make "ASTContext reusing" optional
33336df 
for 'ConformingMethodList' and 'TypeContextInfo'
@rintaro
Copy link
Member Author

rintaro commented Jun 29, 2020

@benlangmuir Made it configurable.

@rintaro
Copy link
Member Author

rintaro commented Jun 29, 2020

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Jun 30, 2020

@swift-ci Please smoke test

@rintaro
Copy link
Member Author

rintaro commented Jun 30, 2020

@swift-ci Please smoke test Linux

@rintaro rintaro merged commit 30ccb52 into swiftlang:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlangmuir benlangmuir benlangmuir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rintaro @swift-ci @benlangmuir