[AutoDiff] Improve invalid stored property projection diagnostics. #32497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `recordValueIfActive` short-circuit, returning true on error. Remove booleans tracking whether diagnostics have been emitted.
Add request that resolves the "tangent stored property" corresponding to an original stored property in a `Differentiable`-conforming type. Enables better non-differentiability differentiation transform diagnostics.
Use TangentStoredPropertyRequest in differentiation transform. Improve non-differentiability diagnostics regarding invalid stored property projection instructions: `struct_extract`, `struct_element_addr`, `ref_element_addr`. Diagnose the following cases: - Original property's type does not conform to `Differentiable`. - Base type's `TangentVector` is not a struct. - Tangent property not found: base type's `TangentVector` does not have a stored property with the same name as the original property. - Tangent property's type is not equal to the original property's `TangentVector` type. - Tangent property is not a stored property. Resolves TF-969 and TF-970.
|
@swift-ci Please smoke test |
rxwei
approved these changes
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a request that resolves the "tangent stored property" corresponding to an
original stored property in a
Differentiable-conforming type.Improve non-differentiability diagnostics regarding invalid stored
property projection instructions:
struct_extract,struct_element_addr,ref_element_addr.Diagnose the following cases:
Differentiable.TangentVectoris not a struct.TangentVectordoes not have astored property with the same name as the original property.
TangentVectortype.Previously, these cases were undiagnosed and crashed with assertion/verification failures.
Resolves TF-969 and TF-970.