Move 'MetadataSections' from 'ImageInspectionElf.h' to SwiftShims #32493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
augusto2112
force-pushed
the
elf-shim-metadata-sections
branch
from
99cec5b to
b74b91c
Compare
compnerd
reviewed
Jun 22, 2020
augusto2112
force-pushed
the
elf-shim-metadata-sections
branch
from
b74b91c to
8c8360b
Compare
|
@compnerd could you start the tests please? :) |
|
@swift-ci please test |
|
I think that this is good to go, and multiple people have reviewed. I still feel like this is unnecessarily splitting up the change, but getting progress is more important than the ideal path. Going to merge this for now so that @augusto2112 can continue making progress. And, thanks @vedantk for helping with this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the
MetadataSectionsdefinition from ImageInspectionELF to SwiftShims. This is part of the work in unifying the definition ofMetadataSections, in order to be used by both ELF and COFF-specific procedures, as well as being acessible from Swift for testing purposes.