[ConstraintSystem] Rework handling of object literal expressions #32481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
approved these changes
Jun 19, 2020
|
@swift-ci please test |
|
@swift-ci please test source compatibility release |
|
Build failed |
|
@swift-ci please test macOS platform |
|
Build failed |
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Instead of special casing argument-to-parameter matching for object literal expressions, let's allow constraint system to lookup a witness initializer and apply it to the given set of arguments. This also simplifies constraint application because `coerceCallArguments` could be used to form type-checked argument expression.
xedin
force-pushed
the
rework-object-literal-typechecking
branch
from
9e69c6a to
02bc2c6
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of special-casing argument-to-parameter matching for
object literal expressions, let's allow constraint system to
lookup a witness initializer and apply it to the given set
of arguments.
This also simplifies constraint application because
coerceCallArgumentscould be used to form type-checkedargument expression.