Skip to content

test: repair the test after #32355 #32457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Conversation

compnerd
Copy link
Member

Fix the tests that #32355 broke.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

CC: @nkcsgexi

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@nkcsgexi
Copy link
Contributor

Thank you, @compnerd ! Could you hold on fixing this after merging #32450? That PR has changed the same test.

@compnerd
Copy link
Member Author

@nkcsgexi - the CI has been broken for ~24h now, I'd like to get CI fixed immediately.

@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@stephentyrone
Copy link
Contributor

Merging to unblock the Windows CI.

@stephentyrone stephentyrone merged commit 1244b5c into swiftlang:master Jun 19, 2020
@compnerd compnerd deleted the 32355 branch June 19, 2020 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants