Give OptionSet an initializer_list constructor #32447
Conversation
|
@swift-ci Please test |
|
Build failed |
|
@swift-ci Please test OS X |
martinboehme
force-pushed
the
option-set-initializer-list
branch
from
af6b58f to
4528dbf
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
| @@ -58,6 +59,10 @@ class OptionSet { | |||
| /// Create an option set with only the given option set. | |||
| constexpr OptionSet(Flags flag) : Storage(static_cast<StorageType>(flag)) {} | |||
|
|
|||
| /// Create an option set containing the given options. | |||
| constexpr OptionSet(std::initializer_list<Flags> flags) | |||
There was a problem hiding this comment.
This constructor cannot be constexpr unless combineFlags is constexpr.
There was a problem hiding this comment.
Huh, of course. Done.
I'm surprised the compiler didn't complain about this?
lib/Index/Index.cpp
Outdated
| ImportFilter |= ModuleDecl::ImportFilterKind::Public; | ||
| ImportFilter |= ModuleDecl::ImportFilterKind::Private; | ||
| ImportFilter |= ModuleDecl::ImportFilterKind::ImplementationOnly; | ||
| ModuleDecl::ImportFilter ImportFilter = { |
| ModuleDecl::ImportFilter ImportFilter; | ||
| ImportFilter |= ModuleDecl::ImportFilterKind::Public; | ||
| ImportFilter |= ModuleDecl::ImportFilterKind::Private; | ||
| ModuleDecl::ImportFilter ImportFilter = { |
There was a problem hiding this comment.
That doesn't work because ImportFilter is modified below.
martinboehme
force-pushed
the
option-set-initializer-list
branch
from
4528dbf to
91674cb
Compare
This makes it easier to specify OptionSet arguments. Also modify appropriate uses of ModuleDecl::ImportFilter to take advantage of the new constructor.
martinboehme
force-pushed
the
option-set-initializer-list
branch
from
91674cb to
d806ba5
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
⛵ |
This makes it easier to specify
OptionSetarguments.Also modify appropriate uses of
ModuleDecl::ImportFilterto take advantage of the new constructor.