IRGen: Lookup the conformance of an archetype in the right substitution map when computing necessary bindings of abstract cnditional requirements #32277
Conversation
…on map when computing necessary bindings of abstract cnditional requirements SR-12853
|
@swift-ci Please test |
lib/IRGen/GenProto.cpp
Outdated
| @@ -2749,9 +2749,12 @@ static void addAbstractConditionalRequirements( | |||
| auto *proto = | |||
| req.getSecondType()->castTo<ProtocolType>()->getDecl(); | |||
| auto ty = req.getFirstType()->getCanonicalType(); | |||
| if (!isa<ArchetypeType>(ty)) | |||
| auto archetype = dyn_cast<ArchetypeType>(ty); | |||
lib/IRGen/GenProto.cpp
Outdated
| auto conformance = subMap.lookupConformance(ty, proto); | ||
| auto *genericEnv = archetype->getGenericEnvironment(); | ||
| auto conformance = | ||
| genericEnv->getForwardingSubstitutionMap().lookupConformance(ty, proto); |
There was a problem hiding this comment.
Is this ever not just an abstract conformance? Look at how the forwarding substitution map is constructed...
There was a problem hiding this comment.
I replaced the check by an assert.
There was a problem hiding this comment.
Can you see if conformance.getAbstract() always equal to proto? If that always holds, you can simplify the code further (and get rid of the asserts since they're not really computing anything useful at this point).
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
|
@swift-ci Please test linux |
|
@swift-ci Please clean test os x |
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
SR-12853