[NFC] Rename SerializeOptionsForDebugging to SerializeOptions #32270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This options is not only used for debugging but also for LTO to serialize detail options.
|
CC: @JDevlieghere IIRC some of the serialization here was original for debugging? |
|
@swift-ci please test |
|
This flag is something we intend to remove in the future. Can we not parameterize this on the LTO flags being present instead? |
|
@CodaFi That makes sense. OK, I'll make a new parameter for LTO |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option is not only used for debugging but also for LTO to
serialize detail options.
This change is pulled out from #32233
CC: @compnerd
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.