Sema: Use PointerEmbeddedInt instead of Fixnum #3009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PointerEmbeddedInt is provided by stock LLVM and serves the same purpose. This updates the coersion function to use that rather than the swift specific Fixnum. Furthermore, this type has been removed in the future in favour of the PointerEmbeddedInt type, which makes this change something which will be needed when rebasing to a newer LLVM release.
|
This is primarily motivated by master-next, but should apply to master cleanly anyways. master-next does not yet contain @DougGregor's change 2b7d0f9 which introduced a new use of Fixnum which has been removed on master-next in favor of llvm::PointerEmbeddedInt. CC @gottesmm |
|
@swift-ci Please smoke test |
|
ping? |
|
Hey, it's WWDC week. :-) |
|
Cool, thanks for fixing this @compnerd! Can Fixnum go away completely? |
|
@lattner my pleasure :-). Yes; I just sent a PR to swift-llvm master to remove the Fixnum header to avoid accidental dependencies in the future. apple/swift-llvm#11 |
|
Cool, keep up the great work! |
kateinoigakukun
added a commit
to kateinoigakukun/swift
that referenced
this pull request
Sep 5, 2021
…1-04-20 Merge main 2021-04-20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
PointerEmbeddedInt is provided by stock LLVM and serves the same purpose. This
updates the coersion function to use that rather than the swift specific Fixnum.
Furthermore, this type has been removed in the future in favour of the
PointerEmbeddedInt type, which makes this change something which will be needed
when rebasing to a newer LLVM release.