[Constraint system] Eliminate global flag UnderlyingTypeForOpaqueReturnType #29487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SolutionResult better captures what can happen when solving a constraint system for the given expression occurs than the ad hoc SolutionKind return & small vector of Solution results. Also, try to make this logic less convoluted.
…ForOpaqueReturnType.
…rnType Make this information contextual (per type) rather than global (per constraint system) so we don’t misapply it.
|
@swift-ci please smoke test |
|
Only the last two commits are unmerged. Huh. |
xedin
reviewed
Jan 28, 2020
| solutions.assign(std::make_move_iterator(ambiguousSolutions.begin()), | ||
| std::make_move_iterator(ambiguousSolutions.end())); | ||
| dumpSolutions(); | ||
| solution.markAsDiagnosed(); |
There was a problem hiding this comment.
Looks like the same 'use-after-move' problem @CodaFi mentioned is present here as well...
There was a problem hiding this comment.
Hmm. It's the same one. I'll roll this into an upcoming PR.
xedin
approved these changes
Jan 28, 2020
DougGregor
deleted the
constraint-system-localized-opaque-result-type-flag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make this information contextual (per type) rather than global (per
constraint system) so we don’t misapply it.