[ConstraintSystem] Be more principled about recording r-value -> l-value fix #26852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If type of the assignment destination expression has been determined to be a r-value type or a type variable which can't be bound to an l-value type, let's fix the type and record a fix for that early.
|
@swift-ci please smoke test |
xedin
force-pushed
the
refactor-treat-r-as-l-value
branch
from
e348ebf
to
0707c2c
Compare
|
@swift-ci please smoke test |
xedin
force-pushed
the
refactor-treat-r-as-l-value
branch
from
0707c2c
to
e706ee3
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test Linux platform |
hborla
approved these changes
Aug 27, 2019
…lue fix Instead of recording `TreatRValueAsLValue` fix directly inside `matchTypes`, let's move towards recording it specifically for each possible case in `repairFailures` which makes it a lot easier to determine what other fixes could be applied (if any).
xedin
force-pushed
the
refactor-treat-r-as-l-value
branch
from
e706ee3
to
1b397ed
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of recording
TreatRValueAsLValuefix directly insidematchTypes, let's move towards recording it specifically foreach possible case in
repairFailureswhich makes it a loteasier to determine what other fixes could be applied (if any).