Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AST] Paren'd reference to an IUO function crashes the compiler in SILGen #26831

Merged
merged 14 commits into from
Aug 30, 2019
Merged

[AST] Paren'd reference to an IUO function crashes the compiler in SILGen #26831

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
32a0c8e
[AST] Strip off parens around an ApplyExpr's function
theblixguy Aug 25, 2019
f02a5f3
[Test] Add a test case
theblixguy Aug 25, 2019
ff7e8b1
[CSSimplify] If we're trying to assign the result of an IUO method wr…
theblixguy Aug 26, 2019
4fd2a4c
[CS] Move the check to CSGen
theblixguy Aug 27, 2019
76c29af
[Test] Adds a test case
theblixguy Aug 27, 2019
0660764
[CS] Move the check to resolveOverload()
theblixguy Aug 27, 2019
b33c520
[CS] Extract the check into a separate lambda
theblixguy Aug 27, 2019
6797148
[CS] Only check for the presence of a paren expr
theblixguy Aug 27, 2019
32cfd5b
[CS] Only check if the decl has a function type
theblixguy Aug 27, 2019
28d0c08
[CSApply] shouldForceUnwrapResult() should return false when we don't…
theblixguy Aug 28, 2019
a2daa11
Merge branch 'master' into fix/SR-10492
theblixguy Aug 28, 2019
532498b
[CSApply] Use the choiceLocator, not locator when checking if a disju…
theblixguy Aug 28, 2019
b32386b
[CS] If locator points to a function call, then compare the fn and se…
theblixguy Aug 29, 2019
fc9fef2
[CS] Be more defensive in isIUOWrappedInParens() check
theblixguy Aug 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/AST/ASTWalker.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@ class Traversal : public ASTVisitor<Traversal, Expr*, Stmt*,

Expr *visitApplyExpr(ApplyExpr *E) {
if (E->getFn()) {
Expr *E2 = doIt(E->getFn());
Expr *E2 = doIt(E->getSemanticFn());
if (E2 == nullptr) return nullptr;
E->setFn(E2);
}
Expand Down
8 changes: 8 additions & 0 deletions validation-test/compiler_crashers_2_fixed/sr10492.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
// RUN: not %target-swift-frontend -emit-silgen %s

struct S {
func foo() -> Int! { return 0 }
}

let s = S()
let x: Int = (s.foo)()