[stdlib] Fix the example in LazySequenceProtocol docs. #24270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure this code ever worked, but this new version does. Also includes some style revisions to the surrounding text.
|
@swift-ci Please smoke test |
|
@swift-ci Please Build Toolchain macOS Platform |
|
macOS Toolchain Install command |
|
@swift-ci Please smoke test |
amartini51
approved these changes
Sep 25, 2019
| /// of the lazy sequence is accessed, an element of the underlying | ||
| /// array is accessed and transformed by the closure. | ||
| /// Each time an element of the lazy sequence `doubled` is accessed, an element | ||
| /// of the underlying array is accessed and transformed by the closure. |
There was a problem hiding this comment.
Is this clearer in passive voice or active voice?
Each time an element of the lazy sequence
doubledis accessed, the closure accesses and transforms an element of the underlying array.
| /// [We don't recommend that you use `map` this way, because it | ||
| /// creates and discards an array. `sum` would be better implemented | ||
| /// using `reduce`]. | ||
| /// Don't actually use `map` for this purpose, however, since it creates |
There was a problem hiding this comment.
ASG uses "since" only in the temporal sense.
Suggested change
| /// Don't actually use `map` for this purpose, however, since it creates | |
| /// Don't actually use `map` for this purpose, however, because it creates |
|
@swift-ci Please smoke test and merge |
1 similar comment
|
@swift-ci Please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this code ever worked, but this new version does. Also includes some style revisions to the surrounding text.