Skip to content

[benchmark] Finish Naming Convention Support #22726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2019

Conversation

palimondo
Copy link
Contributor

These are few commits extracted from #20552, which has been stuck in limbo for a while, to fix the LogParser support for the new Benchmark Naming Convention from #20334 and use the 40 character limit to better align columns in Benchmark_Driver's console output (in -output-dir mode).

…to handle longer benchmark names, assuming maximum length of 40 characters.
Extend parser to support benchmark names that include `-?!` in names, to fully support the new Naming Convention from PR swiftlang#20334.
…to match an actual name from extended Flatten family.
Reordered examples to be sorted alphabetically and ascending by lenght because why not?
@palimondo palimondo requested a review from eeckstein February 19, 2019 22:40
@palimondo
Copy link
Contributor Author

@swift-ci please smoke test

@palimondo
Copy link
Contributor Author

@eeckstein please review 🙏

@palimondo
Copy link
Contributor Author

@swift-ci please benchmark

@palimondo
Copy link
Contributor Author

@swift-ci please smoke test os x platform

@swift-ci
Copy link
Contributor

Performance: -O

TEST OLD NEW DELTA RATIO
Regression
DataAppendDataLargeToLarge 36600 51200 +39.9% 0.71x (?)

Performance: -Osize

TEST OLD NEW DELTA RATIO
Improvement
DictionaryBridgeToObjC_Access 1048 953 -9.1% 1.10x (?)
How to read the data The tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.

If you see any unexpected regressions, you should consider fixing the
regressions before you merge the PR.

Noise: Sometimes the performance results (not code size!) contain false
alarms. Unexpected regressions which are marked with '(?)' are probably noise.
If you see regressions which you cannot explain you can try to run the
benchmarks again. If regressions still show up, please consult with the
performance team (@eeckstein).

Hardware Overview
  Model Name: Mac Pro
  Model Identifier: MacPro6,1
  Processor Name: 12-Core Intel Xeon E5
  Processor Speed: 2.7 GHz
  Number of Processors: 1
  Total Number of Cores: 12
  L2 Cache (per Core): 256 KB
  L3 Cache: 30 MB
  Memory: 64 GB

@palimondo palimondo merged commit e066d45 into swiftlang:master Feb 20, 2019
@palimondo palimondo deleted the cells-interlinked branch May 6, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants