Stop depending on libtensorflow_framework.so just for InitMain(). #20898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-zheng
approved these changes
Nov 30, 2018
|
@swift-ci please test tensorflow |
|
@pschuh This broke all builds and there's no indication that this PR passed any tests. Why was this merged? |
|
Let me revert this PR for now so that Parker can look into it. |
|
@rxwei, never mind. It looks like you already reverted it. |
dan-zheng
added a commit
that referenced
this pull request
Sep 5, 2019
Remove libtensorflow_framework.so as a build product. This reduces toolchain size. Follow-up attempt to #20898.
dan-zheng
added a commit
that referenced
this pull request
Sep 18, 2019
Remove libtensorflow_framework.so as a build product. This reduces toolchain size. Follow-up attempt to #20898.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch over to using InitMain() from tensorflow_framework directly, and then use it through the experimental C api.