stdlib: remove all FIXME(sil-serialize-all) attributes in StringSwitch.swift #20477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@swift-ci benchmark |
1 similar comment
|
@swift-ci benchmark |
airspeedswift
approved these changes
Nov 9, 2018
| @@ -6,6 +6,7 @@ Func MutableCollection._introSort(within:by:) has been removed | |||
| Func MutableCollection._introSortImpl(within:by:depthLimit:) has been removed | |||
| Func MutableCollection._siftDown(_:within:by:) has been removed | |||
| Func MutableCollection._sort3(_:_:_:by:) has been removed | |||
| Func _createStringTableCache(_:) has been removed | |||
There was a problem hiding this comment.
The ABI list is unsorted now, can you group your entries together down the bottom?
|
Thanks! |
eeckstein
force-pushed
the
stringswitch-abi
branch
from
bafe285 to
abdd51e
Compare
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
…h.swift Those attributes were generated automatically, but are not needed. All the annotated declarations are only used stdlib internally rdar://problem/45927899
eeckstein
force-pushed
the
stringswitch-abi
branch
from
abdd51e to
1a02650
Compare
|
@swift-ci smoke test and merge |
1 similar comment
|
@swift-ci smoke test and merge |
Build comment file:Performance: -O
Performance: -Osize
Performance: -Onone
How to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those attributes were generated automatically, but are not needed.
All the annotated declarations are only used stdlib internally
rdar://problem/45927899