[build-script] Fix --enable-tsan-runtime option #13088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
gparker42
reviewed
Nov 27, 2017
| @@ -972,10 +972,6 @@ def create_argument_parser(): | |||
| help="the absolute path to libtool. Default is auto detected.", | |||
| type=arguments.type.executable, | |||
| metavar="PATH") | |||
| parser.add_argument( | |||
| "--distcc", | |||
There was a problem hiding this comment.
I was testing something out locally and mistakenly removed this option. I've added it back.
…e the surrounding tsan options.
Rostepher
force-pushed
the
fix-borked-arguments
branch
from
96c368d to
660bc30
Compare
|
@swift-ci please smoke test |
zisko
suggested changes
Nov 27, 2017
| @@ -990,7 +989,8 @@ def create_argument_parser(): | |||
| action=arguments.action.enable) | |||
| parser.add_argument( | |||
| "--enable-tsan-runtime", | |||
| help="enable Thread Sanitizer on the swift runtime") | |||
| help="enable Thread Sanitizer on the swift runtime", | |||
| action=arguments.action.enable) | |||
There was a problem hiding this comment.
please put help at the last argument here
There was a problem hiding this comment.
I'm not going to do this at the moment. I have that change in a follow-up PR to #12873
zisko
approved these changes
Nov 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the --enable-tsan-runtime option to use the enable action like the surrounding tsan options.