-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[test] Mark tests unsupported on all Linux flavors #1090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Mark tests unsupported on all Linux flavors #1090
Conversation
That's because Linux uses a different autolinking mechanism, based on |
@modocache Could you add that as a comment to the test near the lines that disable it? It would help future maintainers. |
Nice work! I just finished running the test suite on linux-gnueabihf and it works as expected. |
6d4677d
to
b7db0b8
Compare
@gribozavr Updated! Thanks for the advice. It might be useful to expand |
I noticed a few more similar cases, and added your fix to them.
Adding these brings the failing tests on arm-linux+gold to 9. |
@hpux735 Awesome! |
It seems like |
If you need me to, I can send you a PR. However, my repos are in a state of chaos, so it's probably easier for you to do it, if you don't mind. |
Can do! 👍 |
Well, it is not strictly dependent on Objective-C interop. It depends on platforms that support autolinking through LLVM. For example, MSVC linker also supports autolinking. I don't know if LLVM can provide the autolinking information in appropriate format. |
Autolinking was added to the frontend in 22912bc. It was disabled on Linux in 198402d, and further constrained to be disabled on "linux-gnu" in 83b4384. Since then, more flavors of Linux have become supported by Swift: "linux-gnueabihf" in 4bf81e0, and "freebsd" in f41b791. Autolinking most likely does not work on any of these platforms, so mark it as unsupported for now. Other tests that only mark "linux-gnu" as unsupported do so for similar reasons. Ensure unsupported tests for "linux-gnu" are also unsupported on similar platforms.
b7db0b8
to
2eb028b
Compare
@gribozavr I amended the commit to incorporate @hpux735's suggestions. It turns out I had already marked |
…upported-oses [test] Mark tests unsupported on all Linux flavors
Thanks! |
Mirrors swiftlang#1090, but for Android.
These tests should be disabled on all flavors of Linux, not just 'linux-gnu'. See discussion in swiftlang#1090 (comment).
Mirrors swiftlang#1090, but for Android.
These tests should be disabled on all flavors of Linux, not just 'linux-gnu'. See discussion in swiftlang#1090 (comment).
Mirrors swiftlang#1090, but for Android.
These tests should be disabled on all flavors of Linux, not just 'linux-gnu'. See discussion in swiftlang#1090 (comment).
Mirrors swiftlang#1090, but for Android.
These tests should be disabled on all flavors of Linux, not just 'linux-gnu'. See discussion in swiftlang#1090 (comment).
Mirrors swiftlang#1090, but for Android.
These tests should be disabled on all flavors of Linux, not just 'linux-gnu'. See discussion in swiftlang#1090 (comment).
[pull] swiftwasm from master
Autolinking was added to the frontend in 22912bc. It was disabled on Linux in 198402d, and further constrained to be disabled on "linux-gnu" in 83b4384. Since then, more flavors of Linux have become supported by Swift: "linux-gnueabihf" in 4bf81e0, and "freebsd" in f41b791.
Autolinking most likely does not work on any of these platforms, so mark it as unsupported for now.
Why this test is not supported on Linux is beyond my depth. Advice on how to support this test in the future would be greatly appreciated!
/cc @hpux735