The LoadableByAddress pass crashes when building SwiftCompilerSources on Windows with a 5.10 toolchain

[eeckstein]

Description

Crashes with a Unhandled use of FunctionRefInst

Reproduction

Once #73247 lands, revert the "SwiftCompilerSources: workaround a crash in the LoadableByAddress pass when building on Windows" commit of this PR

Expected behavior

no crash

Environment

reproducible with top-of main on Windows

Additional information

No response

[hjyamauchi]

I wonder if this LoadableByAddress crash is the same as #72911 CC @compnerd

[compnerd]

@eeckstein would you be able to test with @aschwaighofer's change? That might easily identify if the fix is already available or if this is another issue with LoadableByAddress.

Edit: aschwaighofer@1f2089a#diff-caf35bb7a5b0aa2a693bff10e95a6b5b903d77784166749ce226e94329a90f2cR3615

[aschwaighofer]

This assert stems from an "older" part of the code the above fix will not fix it

[hjyamauchi]

@eeckstein https://github.com/apple/swift/pull/73270/files fixed #72911

[eeckstein]

Seems to be fixed in Swift 6.0