Crash in LLVM when compiling SwiftCompilerSources on Windows with a 5.10 toolchain

[eeckstein]

Description

The problem occurs when calling the C++ imported function from public func getFunctionType(withNoEscape: Bool) -> Type in Type.swift.

Crashes in LLVM with:

Attribute 'zeroext' applied to incompatible type!
  call void @"?getFunctionTypeWithNoEscape@BridgedType@@QEBA?AU1@_N@Z"(ptr %3, ptr zeroext sret(%struct.BridgedType) %4, i1 %0)

Reproduction

Once #73247 lands, revert the "SwiftCompilerSources: workaround a compiler crash on windows by disabling convert_function simplification" commit of this PR

Expected behavior

no crash

Environment

reproducible with top-of main on Windows

Additional information

No response

[eeckstein]

Still happening in Swift 6.0

[eeckstein]

The problem seems to be that the zeroext attribute is added to the wrong argument. It should be added to the next argument which is a bool (i1).