Clean up some trivially true condition clauses

ProtocolConformanceRef::isConcrete checks the invalid bit for us.

Author: CodaFi

lib/IDE/CodeCompletion.cpp

@@ -2107,7 +2107,7 @@ class CompletionLookup final : public swift::VisibleDeclConsumer {
         auto *Module = NTD->getParentModule();
         auto Conformance = Module->lookupConformance(
             BaseTy, ATD->getProtocol());
-        if (!Conformance.isInvalid() && Conformance.isConcrete()) {
+        if (Conformance.isConcrete()) {
           return Conformance.getConcrete()->getTypeWitness(
               const_cast<AssociatedTypeDecl *>(ATD));
         }

lib/ParseSIL/ParseSIL.cpp

@@ -6322,7 +6322,7 @@ bool SILParserTUState::parseSILWitnessTable(Parser &P) {
 
   // FIXME: should we really allow a specialized or inherited conformance here?
   RootProtocolConformance *theConformance = nullptr;
-  if (!conf.isInvalid() && conf.isConcrete())
+  if (conf.isConcrete())
     theConformance = conf.getConcrete()->getRootConformance();
 
   SILWitnessTable *wt = nullptr;

lib/SILGen/SILGen.cpp

@@ -352,7 +352,7 @@ ProtocolConformance *SILGenModule::getNSErrorConformanceToError() {
     SwiftModule->lookupConformance(nsError->getDeclaredInterfaceType(),
                                    cast<ProtocolDecl>(error));
 
-  if (!conformance.isInvalid() && conformance.isConcrete())
+  if (conformance.isConcrete())
     NSErrorConformanceToError = conformance.getConcrete();
   else
     NSErrorConformanceToError = nullptr;

lib/Sema/CSApply.cpp

@@ -436,7 +436,7 @@ namespace {
               TypeChecker::conformsToProtocol(
                         baseTy, proto, cs.DC,
                         ConformanceCheckFlags::InExpression);
-            if (!conformance.isInvalid() && conformance.isConcrete()) {
+            if (conformance.isConcrete()) {
               if (auto witness =
                       conformance.getConcrete()->getWitnessDecl(decl)) {
                 // Hack up an AST that we can type-check (independently) to get

lib/Sema/TypeCheckProtocol.cpp

@@ -3043,7 +3043,7 @@ ConformanceChecker::resolveWitnessViaLookup(ValueDecl *requirement) {
       auto derivableProto = cast<ProtocolDecl>(derivable->getDeclContext());
       auto conformance =
           TypeChecker::conformsToProtocol(Adoptee, derivableProto, DC, None);
-      if (!conformance.isInvalid() && conformance.isConcrete()) {
+      if (conformance.isConcrete()) {
         (void)conformance.getConcrete()->getWitnessDecl(derivable);
       }
     }

lib/Sema/TypeCheckType.cpp

@@ -898,7 +898,7 @@ static void maybeDiagnoseBadConformanceRef(DeclContext *dc,
         (ConformanceCheckFlags::InExpression |
          ConformanceCheckFlags::SuppressDependencyTracking |
          ConformanceCheckFlags::SkipConditionalRequirements));
-    if (!conformanceRef.isInvalid() && conformanceRef.isConcrete())
+    if (conformanceRef.isConcrete())
       conformance = conformanceRef.getConcrete();
   }