Commit e6b7808
committed
[build-presets] Remove
I added the test-sourcekit-lsp command because I thought that we weren’t running sourcekit-lsp tests on the swift-syntax PR testing job (#72030). Then the job started failing with a TSAN failure and I thought that we would now not run sourcekit-lsp tests on the sourcekit-lsp PR testing job, so I added it there as well.
Turns out that my first assumption that we weren’t running sourcekit-lsp tests on swift-syntax PRs was wrong and the downstream failure of that was just due to racing PRs. Furthermore, the `test-sourcekit-lsp` flag doesn’t even exist. Instead, it got typo-corrected (?) to `test-sourcekit-lsp-sanitize-all`, which enabled the TSAN sanitizer on the swift-syntax and sourcekit-lsp PR testing jobs. And that caused test failures.
So, remove the `test-sourcekit-lsp` arguments again. After I made sourcekit-lsp build with strict concurrency / Swift 6 mode, I’ll re-enable TSAN on the sourcekit-lsp PR tests and fix any remaining TSAN issues.test-sourcekit-lsp
1 parent 857a6c3 commit e6b7808
1 file changed
+0
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1878 | 1878 | | |
1879 | 1879 | | |
1880 | 1880 | | |
1881 | | - | |
1882 | 1881 | | |
1883 | 1882 | | |
1884 | 1883 | | |
| |||
1935 | 1934 | | |
1936 | 1935 | | |
1937 | 1936 | | |
1938 | | - | |
1939 | 1937 | | |
1940 | 1938 | | |
1941 | 1939 | | |
| |||
0 commit comments