fix 28241-swift-valuedecl-isaccessiblefrom.swift

Author: lattner

lib/Sema/CSDiag.cpp

@@ -911,7 +911,8 @@ void CalleeCandidateInfo::filterList(ClosenessPredicate predicate) {
 
       // Likewise, if the candidate is inaccessible from the scope it is being
       // accessed from, mark it as inaccessible or a general mismatch.
-      if (!VD->isAccessibleFrom(CS->DC)) {
+      if (VD->hasAccessibility() &&
+          !VD->isAccessibleFrom(CS->DC)) {
         // If this was an exact match, downgrade it to inaccessible, so that
         // accessible decls that are also an exact match will take precedence.
         // Otherwise consider it to be a general mismatch so we only list it in

validation-test/compiler_crashers/28241-swift-valuedecl-isaccessiblefrom.swift renamed to validation-test/compiler_crashers_fixed/28241-swift-valuedecl-isaccessiblefrom.swift

@@ -1,5 +1,4 @@
-// RUN: not --crash %target-swift-frontend %s -parse
-// REQUIRES: asserts
+// RUN: not %target-swift-frontend %s -parse
 
 // Distributed under the terms of the MIT license
 // Test case submitted to project by https://github.com/practicalswift (practicalswift)