Merge pull request #327 from erg/linux-warnings

Fix eight warnings on Linux.

Author: slavapestov

lib/IDE/SyntaxModel.cpp

@@ -1291,10 +1291,7 @@ bool ModelASTWalker::processComment(CharSourceRange Range) {
 bool ModelASTWalker::findUrlStartingLoc(StringRef Text,
                                         unsigned &Start,
                                         std::regex &Regex) {
-#ifndef SWIFT_HAVE_WORKING_STD_REGEX
-  return false;
-#endif
-
+#ifdef SWIFT_HAVE_WORKING_STD_REGEX
   static const auto MailToPosition = std::find(URLProtocols.begin(),
                                                URLProtocols.end(),
                                                "mailto");
@@ -1318,6 +1315,7 @@ bool ModelASTWalker::findUrlStartingLoc(StringRef Text,
       return true;
     }
   }
+#endif
   return false;
 }
 
@@ -1354,10 +1352,8 @@ bool ModelASTWalker::searchForURL(CharSourceRange Range) {
 Optional<SyntaxNode> ModelASTWalker::parseFieldNode(StringRef Text,
                                                     StringRef OrigText,
                                                     SourceLoc OrigLoc) {
-#ifndef SWIFT_HAVE_WORKING_STD_REGEX
-  return None;
-#endif
-
+  Optional<SyntaxNode> Node;
+#ifdef SWIFT_HAVE_WORKING_STD_REGEX
   std::match_results<StringRef::iterator> Matches;
   for (unsigned i = 0; i != 3; ++i) {
     auto &Rx = getDocCommentRegex(i);
@@ -1372,7 +1368,9 @@ Optional<SyntaxNode> ModelASTWalker::parseFieldNode(StringRef Text,
   StringRef MatchStr(Match.first, Match.second - Match.first);
   auto Loc = OrigLoc.getAdvancedLoc(MatchStr.data() - OrigText.data());
   CharSourceRange Range(Loc, MatchStr.size());
-  return Optional<SyntaxNode>({ SyntaxNodeKind::DocCommentField, Range });
+  Node = Optional<SyntaxNode>({ SyntaxNodeKind::DocCommentField, Range });
+#endif
+  return Node;
 }
 
 bool ModelASTWalker::findFieldsInDocCommentLine(SyntaxNode Node) {

lib/Immediate/REPL.cpp

@@ -130,6 +130,7 @@ class ConvertForWcharSize<4> {
 
 using Convert = ConvertForWcharSize<sizeof(wchar_t)>;
 
+#if defined(__APPLE__)
 static void convertFromUTF8(llvm::StringRef utf8,
                             llvm::SmallVectorImpl<wchar_t> &out) {
   size_t reserve = out.size() + utf8.size();
@@ -157,9 +158,12 @@ static void convertToUTF8(llvm::ArrayRef<wchar_t> wide,
   (void)res;
   out.set_size(utf8_begin - out.begin());
 }
+#endif
 
 } // end anonymous namespace
 
+#if defined(__APPLE__)
+
 static bool appendToREPLFile(SourceFile &SF,
                              PersistentParserState &PersistentState,
                              REPLContext &RC,
@@ -183,8 +187,6 @@ static bool appendToREPLFile(SourceFile &SF,
   return FoundAnySideEffects;
 }
 
-#if defined(__APPLE__)
-
 /// An arbitrary, otherwise-unused char value that editline interprets as
 /// entering/leaving "literal mode", meaning it passes prompt characters through
 /// to the terminal without affecting the line state. This prevents color

lib/SILAnalysis/AliasAnalysis.cpp

@@ -368,8 +368,8 @@ static bool isTypedAccessOracle(SILInstruction *I) {
 /// address is with pointer_to_address (via UnsafePointer) or
 /// unchecked_addr_cast (via Builtin.reinterpretCast). Consequently, if the
 /// given value is directly derived from a memory location, it cannot
-/// alias. Call arguments also cannot alias because they must follow @in, @out,
-/// @inout, or @in_guaranteed conventions.
+/// alias. Call arguments also cannot alias because they must follow \@in, @out,
+/// @inout, or \@in_guaranteed conventions.
 ///
 /// FIXME: pointer_to_address should contain a flag that indicates whether the
 /// address is aliasing. Currently, we aggressively assume that

stdlib/public/runtime/Casting.cpp

@@ -1388,6 +1388,7 @@ swift::swift_dynamicCastMetatypeUnconditional(const Metadata *sourceType,
   }
 }
 
+#if SWIFT_OBJC_INTEROP
 /// Do a dynamic cast to the target class.
 static void *_dynamicCastUnknownClass(void *object,
                                       const Metadata *targetType,
@@ -1400,6 +1401,7 @@ static void *_dynamicCastUnknownClass(void *object,
 
   return const_cast<void*>(swift_dynamicCastUnknownClass(object, targetType));
 }
+#endif
 
 static bool _dynamicCastUnknownClassIndirect(OpaqueValue *dest,
                                              void *object,