Make Atomic.deinit @_transparent

Author: meg-gupta

include/swift/AST/DeclAttr.def

@@ -102,7 +102,7 @@ DECL_ATTR(_semantics, Semantics,
   OnAbstractFunction | OnSubscript | OnNominalType | OnVar | AllowMultipleAttributes | UserInaccessible | ABIStableToAdd | ABIStableToRemove | APIStableToAdd | APIStableToRemove,
   21)
 SIMPLE_DECL_ATTR(_transparent, Transparent,
-  OnFunc | OnAccessor | OnConstructor | OnVar | UserInaccessible | ABIStableToAdd | ABIStableToRemove | APIStableToAdd | APIStableToRemove,
+  OnFunc | OnAccessor | OnConstructor | OnVar | OnDestructor | UserInaccessible | ABIStableToAdd | ABIStableToRemove | APIStableToAdd | APIStableToRemove,
   26)
 SIMPLE_DECL_ATTR(requires_stored_property_inits, RequiresStoredPropertyInits,
   OnClass | ABIStableToAdd | ABIStableToRemove | APIStableToAdd | APIStableToRemove,

lib/SILOptimizer/Mandatory/PredictableMemOpt.cpp

@@ -1037,6 +1037,9 @@ void AvailableValueAggregationFixup::addHandOffCopyDestroysForPhis(
 // TODO: use standard lifetime completion
 void AvailableValueAggregationFixup::addMissingDestroysForCopiedValues(
     SILInstruction *load, SILValue newVal) {
+  if (!load->getFunction()->hasOwnership()) {
+    load->getFunction()->dump();
+  }
   assert(load->getFunction()->hasOwnership() &&
          "We assume this is only called if we have ownership");
 

stdlib/public/Synchronization/Atomics/Atomic.swift

@@ -42,11 +42,10 @@ public struct Atomic<Value: AtomicRepresentable>: ~Copyable {
     _address.initialize(to: Value.encodeAtomicRepresentation(initialValue))
   }
 
-  // Deinit's can't be marked @_transparent. Do these things need all of these
-  // attributes..?
   @available(SwiftStdlib 6.0, *)
   @_alwaysEmitIntoClient
   @inlinable
+  @_transparent
   deinit {
     let oldValue = Value.decodeAtomicRepresentation(_address.pointee)
     _ = consume oldValue

test/attr/attributes.swift

@@ -68,7 +68,7 @@ protocol ProtoWithTransparent {
 class TestTranspClass : ProtoWithTransparent {
   @_transparent  // expected-error{{'@_transparent' attribute is not supported on declarations within classes}} {{3-17=}}
   init () {}
-  @_transparent // expected-error{{'@_transparent' attribute cannot be applied to this declaration}} {{3-17=}}
+  @_transparent // expected-error{{'@_transparent' attribute is not supported on declarations within classes}} {{3-17=}}
   deinit {}
   @_transparent // expected-error{{'@_transparent' attribute is not supported on declarations within classes}} {{3-17=}}
   class func transStatic() {}