Fix memory issue with error strings

DavidGoldman · DavidGoldman · commit 8d58ba840583 · 2019-05-28T10:13:43.000-04:00
diff --git a/tools/SourceKit/tools/sourcekitd/lib/API/sourcekitdAPI-XPC.cpp b/tools/SourceKit/tools/sourcekitd/lib/API/sourcekitdAPI-XPC.cpp
@@ -380,8 +380,8 @@ sourcekitd::createErrorRequestInvalid(const char *Description) {
 }
 sourcekitd_response_t
 sourcekitd::createErrorRequestFailed(StringRef DescRef) {
-  const char *Description = DescRef.str().c_str();
-  return CustomXPCData::createErrorRequestFailed(Description).getXObj();
+  std::string Desc = DescRef.str();
+  return CustomXPCData::createErrorRequestFailed(Desc.c_str()).getXObj();
 }
 sourcekitd_response_t
 sourcekitd::createErrorRequestInterrupted(const char *Description) {

Original file line number	Diff line number	Diff line change
`@@ -380,8 +380,8 @@ sourcekitd::createErrorRequestInvalid(const char *Description) {`
`380`	`380`	`}`
`381`	`381`	`sourcekitd_response_t`
`382`	`382`	`sourcekitd::createErrorRequestFailed(StringRef DescRef) {`
`383`		`- const char *Description = DescRef.str().c_str();`
`384`		`- return CustomXPCData::createErrorRequestFailed(Description).getXObj();`
	`383`	`+ std::string Desc = DescRef.str();`
	`384`	`+ return CustomXPCData::createErrorRequestFailed(Desc.c_str()).getXObj();`
`385`	`385`	`}`
`386`	`386`	`sourcekitd_response_t`
`387`	`387`	`sourcekitd::createErrorRequestInterrupted(const char *Description) {`