Merge pull request #32402 from zoecarver/cxx/non-trival-with-destructor

Author: swift-ci

lib/SIL/IR/TypeLowering.cpp

@@ -1453,6 +1453,7 @@ namespace {
 
       if (D->isCxxNotTriviallyCopyable()) {
         properties.setAddressOnly();
+        properties.setNonTrivial();
       }
 
       auto subMap = structType->getContextSubstitutionMap(&TC.M, D);

test/Interop/Cxx/class/Inputs/module.modulemap

@@ -2,8 +2,8 @@ module AccessSpecifiers {
   header "access-specifiers.h"
 }
 
-module LoadableTypes {
-  header "loadable-types.h"
+module TypeClassification {
+  header "type-classification.h"
 }
 
 module MemberwiseInitializer {

test/Interop/Cxx/class/Inputs/loadable-types.h renamed to test/Interop/Cxx/class/Inputs/type-classification.h

@@ -80,7 +80,7 @@ struct StructWithSubobjectMoveAssignment {
 };
 
 struct StructWithDestructor {
-  ~StructWithDestructor(){}
+  ~StructWithDestructor() {}
 };
 
 struct StructWithInheritedDestructor : StructWithDestructor {};

test/Interop/Cxx/class/loadable-types-silgen.swift renamed to test/Interop/Cxx/class/type-classification-loadable-silgen.swift

@@ -3,7 +3,7 @@
 // This test checks that we classify C++ types as loadable and address-only
 // correctly.
 
-import LoadableTypes
+import TypeClassification
 
 // Tests for individual special members
 

test/Interop/Cxx/class/type-classification-non-trivial-silgen.swift

@@ -0,0 +1,25 @@
+// RUN: %target-swift-frontend -I %S/Inputs -enable-cxx-interop -emit-sil %s | %FileCheck %s
+
+import TypeClassification
+
+// Make sure that "StructWithDestructor" is marked as non-trivial by checking for a
+// "destroy_addr".
+// CHECK-LABEL: @$s4main24testStructWithDestructoryyF
+// CHECK: [[AS:%.*]] = alloc_stack $StructWithDestructor
+// CHECK: destroy_addr [[AS]]
+// CHECK-LABEL: end sil function '$s4main24testStructWithDestructoryyF'
+public func testStructWithDestructor() {
+  let d = StructWithDestructor()
+}
+
+// Make sure that "HasMemberWithDestructor" is marked as non-trivial by checking
+// for a "destroy_addr".
+// CHECK-LABEL: @$s4main33testStructWithSubobjectDestructoryyF
+// CHECK: [[AS:%.*]] = alloc_stack $StructWithSubobjectDestructor
+// CHECK: destroy_addr [[AS]]
+// CHECK-LABEL: end sil function '$s4main33testStructWithSubobjectDestructoryyF'
+public func testStructWithSubobjectDestructor() {
+  let d = StructWithSubobjectDestructor()
+}
+
+