Merge pull request #71692 from aschwaighofer/metadata_reader_fix_objc_sym_refs

MetadataReader: Allow for an unresolved pointer to be returned by getSymbol

Author: aschwaighofer

include/swift/Remote/MetadataReader.h

@@ -517,13 +517,30 @@ class MetadataReader {
         // 'resolved' points to a struct of two relative addresses.
         // The second entry is a relative address to the mangled protocol
         // without symbolic references.
+
+        // lldb might return an unresolved remote absolute pointer from its
+        // resolvePointerAsSymbol implementation -- workaround this.
+        if (!resolved.isResolved()) {
+          auto remoteAddr = RemoteAddress(remoteAddress);
+          resolved =
+            RemoteAbsolutePointer("", remoteAddr.getAddressData());
+        }
+
         auto addr =
             resolved.getResolvedAddress().getAddressData() + sizeof(int32_t);
         int32_t offset;
         Reader->readInteger(RemoteAddress(addr), &offset);
         auto addrOfTypeRef = addr + offset;
         resolved = Reader->getSymbol(RemoteAddress(addrOfTypeRef));
 
+        // lldb might return an unresolved remote absolute pointer from its
+        // resolvePointerAsSymbol implementation -- workaround this.
+        if (!resolved.isResolved()) {
+          auto remoteAddr = RemoteAddress(addrOfTypeRef);
+          resolved =
+            RemoteAbsolutePointer("", remoteAddr.getAddressData());
+        }
+
         // Dig out the protocol from the protocol list.
         auto protocolList = readMangledName(resolved.getResolvedAddress(),
                                             MangledNameKind::Type, dem);