Skip to content

Commit 3b0dd5d

Browse files
committed
Fixed hard-coded default values in the expected_options module used for generating argument parser tests.
1 parent f53a214 commit 3b0dd5d

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

utils/build_swift/tests/expected_options.py

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99

1010
import multiprocessing
1111

12+
from swift_build_support.swift_build_support import host
13+
from swift_build_support.swift_build_support import targets
14+
1215
from .. import argparse
1316
from .. import defaults
1417

@@ -123,12 +126,9 @@
123126
'host_cxx': None,
124127
'host_libtool': None,
125128
'host_lipo': None,
126-
# FIXME: determine actual default value rather than hardcode
127-
'host_target': 'macosx-x86_64',
129+
'host_target': targets.StdlibDeploymentTarget.host_target().name,
128130
'host_test': False,
129-
# FIXME: determine actual default value rather than hardcode
130-
'install_prefix': '/Applications/Xcode.app/Contents/Developer/Toolchains/'
131-
'XcodeDefault.xctoolchain/usr',
131+
'install_prefix': targets.install_prefix(),
132132
'install_symroot': None,
133133
'ios': False,
134134
'ios_all': False,
@@ -140,7 +140,8 @@
140140
'lldb_build_variant': 'Debug',
141141
'llvm_assertions': True,
142142
'llvm_build_variant': 'Debug',
143-
'llvm_max_parallel_lto_link_jobs': 0,
143+
'llvm_max_parallel_lto_link_jobs':
144+
host.max_lto_link_job_counts()['llvm'],
144145
'llvm_targets_to_build': 'X86;ARM;AArch64;PowerPC;SystemZ;Mips',
145146
'long_test': False,
146147
'lto_type': None,
@@ -153,7 +154,8 @@
153154
'swift_compiler_version': None,
154155
'swift_stdlib_assertions': True,
155156
'swift_stdlib_build_variant': 'Debug',
156-
'swift_tools_max_parallel_lto_link_jobs': 0,
157+
'swift_tools_max_parallel_lto_link_jobs':
158+
host.max_lto_link_job_counts()['swift'],
157159
'swift_user_visible_version': defaults.SWIFT_USER_VISIBLE_VERSION,
158160
'symbols_package': None,
159161
'test': None,

0 commit comments

Comments
 (0)