Skip to content

Commit 1d6b2a3

Browse files
Validation tests don't define llvm_plugin_ext
This caused a Windows-specific error in https://github.com/llvm/llvm-project/blob/2f7d3ec02349d4503e1fa8c54665025eb4f8e173/llvm/utils/lit/lit/TestRunner.py#L1790
1 parent 260ed3b commit 1d6b2a3

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

test/lit.cfg

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -239,7 +239,9 @@ elif platform.system() == 'Darwin':
239239
config.substitutions.append( ('%lto_flags', lto_flags) )
240240
config.substitutions.append( ('%use_just_built_liblto', use_just_built_liblto) )
241241
config.substitutions.append( ('%llvm_libs_dir', llvm_libs_dir) )
242-
config.substitutions.append( ('%llvm_plugin_ext', llvm_plugin_ext) )
242+
243+
if llvm_plugin_ext is not None:
244+
config.substitutions.append( ('%llvm_plugin_ext', llvm_plugin_ext) )
243245

244246
# Allow tests to restore the original environment if they need to.
245247
config.substitutions.append( ('%original_path_env', config.environment['PATH']) )

0 commit comments

Comments
 (0)