Configure CMake to build and install the Foundation cross-import overlay #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
added
enhancement
stmontgomery
requested review from
SeanROlszewski,
briancroom,
dennisweissmann,
grynspan and
suzannaratcliff
as code owners
stmontgomery
commented
Nov 18, 2024
2 tasks
stmontgomery
added a commit
that referenced
this pull request
Nov 19, 2024
This fixes an oversight in a helper function in the project’s CMake rules: `_swift_testing_install_target()` has a hard-coded reference to the target named ”Testing” but it should instead refer to whatever target was passed in via the `module` argument to the function. Discovered while working on #825. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
stmontgomery
force-pushed
the
cmake-crossimports
branch
from
4198b0f to
1ca8866
Compare
stmontgomery
force-pushed
the
cmake-crossimports
branch
from
1334b65 to
1681f3c
Compare
Contributor
Author
|
@swift-ci please test |
briancroom
approved these changes
Nov 21, 2024
Contributor
Author
|
@swift-ci please test |
grynspan
added
the
cross-import-overlays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This augments the project's CMake rules to begin building and installing the Foundation cross-import overlay (
_Testing_Foundation), including the associated.swiftcrossimportdirectory which causes the overlay to be applied to clients.Checklist:
Resolves rdar://139877808